Capability improvements to enable TDS #135
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I created #136 to potentially add deprecated tests in CIVET recipes since it would be nice to run them here. |
|
Job Documentation on 9465d95 wanted to post the following: View the site here This comment will be updated on new commits. |
|
@simopier should have time to give this a full review tomorrow. |
cticenhour
requested changes
May 24, 2024
- Add recommended units - Spell out temperature instead of temp
- Add ability to feed Ct0 as a function - Add detrapping energy and temperature dependence - Clean up
- Add ability to feed Ct0 as a function
and fix typo
clean up test file name
…closure_scalar_var and replace it with enclosure_var -Edit tests input files
Co-authored-by: Casey Icenhour <[email protected]>
simopier
force-pushed
the
TMAP8_benchmark_PSI_Case
branch
from
a6cb98c to
3cd0678
Compare
cticenhour
requested changes
May 28, 2024
Co-authored-by: Casey Icenhour <[email protected]>
cticenhour
approved these changes
May 28, 2024
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR improves current TMAP8 to support thermal desorption spectroscopy (TDS) modeling.
The commit messages describe what is being done.
(Ref. #133) - a follow up PR will add an example case for TDS to complete this issue, but this PR already grew large enough..
(Close. #134)