Move Feedback Form to Asana #546
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
this would be an API issue, not something that we should hard-code anyways
|
LGTM, but I would suggest having a dedicated env variable for the feedback form link instead of replacing every occurrence of it in case it changes later. |
timobraz
approved these changes
Jan 7, 2025
|
@charlieweinberger ready for your review |
|
@timobraz we could consider that for the future, but we'd either have to create a new route to redirect to the form, or find a way to define frontend env variables since tmk that does not exist yet. |
|
LGTM, other than one tiny tiny thing. The description of the "How can we improve?" question mentions an option labeled "Issue/Bug" for the previous question, but the previous question lists just "Bug" as an option, not "Issue" or "Issue/Bug". Other than that, looks good. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR changes the Google Form link into the Asana feedback form. Additionally, the missing professor Google Form link is removed because professors populate from the API, and as such, issues should go to them instead.
Reviewers
@timobraz requesting your review as primary review for code
@charlieweinberger review staging instance, and look at code if you want.
Screenshots
N/A
Test Plan
Check that the staging instance links to Asana feedback forms instead of Google Forms. There should only be two places, but let me know if there are any I missed:
Issues
Closes #540
Asana Task: https://app.asana.com/0/1208487280290067/1208487339635800/f