-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: links/client side navigation #433
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
addressed in another pr
Awesome-E
approved these changes
Mar 6, 2024
since filtering by professor has been added, this option can persist if a user navigates to another page by clicking a course in prereq tree
courseGQLData only updates after search result returns, id can be mismatched. use courseGQLData.id
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Some anchor tags were used to link to other pages. Link tags need to be used instead to use react router properly for client side navigation. Also had to fix some useEffect dependencies and keys in some components because data was persisting between changing courses, professors, etc. now that we're actually navigating on the client and not reloading the page.
Next Steps
I think I took care of everything to make navigation work properly but we should do the above steps to be sure and to avoid any inevitable errors that may occur in the future.
Steps to verify/test this change:
Final Checks:
(optional)
Issues
Closes #