Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a filter by course or professor to reviews #429

Merged
merged 14 commits into from
Feb 22, 2024
Merged

Conversation

ptruong0
Copy link
Contributor

Description

New dropdown next to the sort option that lists professors for course page and courses for professor page. Filter respective results when the dropdown is changed.

Screenshots

Course Page (no filter selected i.e. show all)
image

Course Page (selected)
image

Course Page (no reviews for selected professor)
image

Professor Page (selected)
image

Course Page (no reviews for selected professor)
image

Steps to verify/test this change:

  • Verify changes work as expected on staging instance

Final Checks:

  • Verify successful deployment

(optional)

  • Write tests
  • Write documentation

Issues

Closes #311

@ptruong0 ptruong0 requested a review from js0mmer February 14, 2024 09:15
@ptruong0 ptruong0 self-assigned this Feb 15, 2024
Copy link
Member

@js0mmer js0mmer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you sort the options in the dropdowns alphabetically? Other than that, looks good!

We may also want to consider only showing options that have reviews. Perhaps we can do what rate my professor does as well and show the number of reviews for that option:

image

@ptruong0 ptruong0 requested a review from js0mmer February 19, 2024 01:18
Copy link
Member

@js0mmer js0mmer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Couple small suggestions. Other than that, LGTM!

site/src/component/Review/Review.tsx Outdated Show resolved Hide resolved
site/src/component/Review/Review.tsx Outdated Show resolved Hide resolved
@ptruong0 ptruong0 merged commit 0ef268c into master Feb 22, 2024
3 checks passed
@ptruong0 ptruong0 deleted the phil/review-filter branch February 22, 2024 08:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add a filter by course or professor to reviews
2 participants