Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean up unused files, backend packages, etc. #396

Merged
merged 29 commits into from
Jan 21, 2024
Merged

Conversation

js0mmer
Copy link
Member

@js0mmer js0mmer commented Dec 19, 2023

Description

  • Removed some unused files/code
  • Removed unused packages on backend
  • Removed bin/www
  • Cleaned up gitignore, tsconfig, express app.ts

Next steps:

  • Update packages on backend
    • Notably, the MongoDB driver is 3 major versions behind and I am reluctant to upgrade it because I think our time would be better spent just switching to mongoose or Prisma. This could be a PR of it's own.
  • Remove unused express routes
    • Everything that's not used or not helpful should be removed now.
    • There's some unused routes for requesting a single professor and single course that we honestly should use. I don't like how the same batch route is used for course/professor pages and the catalogue page, search times could probably be improved by selecting fewer attributes. I think it would also make more sense to call websoc fuzzy search on the backend and just send the query to the backend
  • Add eslint to backend (Add eslint to the backend #400)
  • Remove unneeded console logs
    • there are a few left behind on the frontend on course pages and the catalogue page. I've left them in for now because our search could use some work, these logs can be dealt with then
    • there are also still some left in the express server. it would be good if we could keep them in dev but drop them from the production build

I plan to address updating backend packages (with the exception of the mongo driver) alongside adding eslint in a separate PR since these will introduce breaking changes.

Steps to verify/test this change:

  • Verify changes work as expected on staging instance

Final Checks:

  • Verify successful deployment
  • Delete branch

(optional)

  • Write tests
  • Write documentation

Issues

Closes #365

@js0mmer js0mmer self-assigned this Dec 19, 2023
Copy link

Deployed staging instance to https://staging-396.peterportal.org

@js0mmer js0mmer merged commit 24e29fb into master Jan 21, 2024
2 checks passed
@js0mmer js0mmer deleted the spring-cleaning branch January 21, 2024 20:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Clean up old files in repository
1 participant