-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Migrate to vite #375
Migrate to vite #375
Conversation
…ove unused packages
…ed versions of react-router-dom and nivo
Professor ID wasn't being submitted. Made the code less scuffed.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I tested the basic of the website instance, everything seems to work the same as the prod ones. I checked mainly on the review, sub review and review form since I am familiar with those codes. Good changes on the readability of the codes. I think it is good to go. Good job! (But Goddamn 73 files changes O.O)
Co-authored-by: Jacob Sommer <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, everything seems to work.
* feat: initial migrate test * feat: stable ground (no more ts errors) * feat: everything works(?) * fix: update footer * feat: more cleanup * fix: properly case GitHub * fix: sort grade dist quarter dropdown, misc fixes * fix: use async because it is almost 2024 * fix: address most comment changes * fix: show class title in prereq tree nodes, correct links * fix: less bad solution for prereq titles * feat: fetch course/instructor data on demand * fixed prereq box to only appear when there is text (#367) * fix: grab review form fix from #375 Co-authored-by: Jacob Sommer <[email protected]> * feat: use graphql for courses again, set endpoint to staging * chore: migrate to latest api staging * fix: make prereq tree node labels consistently spaced * fix: reincorporate #391 changes * feat: migrate to latest staging, hopefully fix perf issues * Fix review form merging * Restore original transformation fucntions * Restore API url env vars --------- Co-authored-by: Kyle Pan <[email protected]> Co-authored-by: Jacob Sommer <[email protected]> Co-authored-by: Jacob Sommer <[email protected]>
Deployed staging instance to https://staging-375.peterportal.org |
Description
npm run lint -- --fix
) to fix some eslint errors (unused vars and stuff)Next steps
Steps to verify/test this change:
Final Checks:
(optional)
Issues
Closes #362