-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add dark mode & refactor styling #323
Conversation
Fun little thing that you don't have to do – if you want to make the captcha respect dark mode, you can apply the following style to the Recaptcha's iframe: #some-identifier {
filter: invert(1) hue-rotate(180deg);
} This only changes the I'm not a robot dialog and won't affect the actual image selector |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This text/button looks to be a little bit low contrast. I know not all of the buttons follow the "proper contrast ratios" (I don't really care too much for that tbh 🙃), but since this one uses that color for just text it makes it a little bit harder to see than I'd like.
The borders here should have a dark mode equivalent; having light gray instead of a darker variant makes it a little jarring
Current:
Using Dark reader chrome extension:
Also noticed the extra whitespace with Google Recaptcha not following theme, which is annoying. Not sure if you'd want to implement a monkeypatch for that though
Course planner looks fine except for the same thing with borders as mentioned above.
Reviews and verify reviews look good
0239ae9
to
0c63c43
Compare
Deployed staging instance to https://staging-323.peterportal.org |
Description
[data-theme='dark']
css selector/api/users/preferences
)Other changes
Future changes to implement
Make searching.png (search image on home page) look less jagged(Add new search graphic #376)Additional information on the implementation can be found on the styling wiki page.
Closes #9.
Screenshots
Steps to verify/test this change:
Final Checks:
(optional)