Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Install PWA button #1134

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

feat: Install PWA button #1134

wants to merge 3 commits into from

Conversation

xgraceyan
Copy link
Contributor

Summary

  • Adds an "Install App" button to the Header for easy PWA installation.
    image

  • Button changes to just icon in mobile view, to ensure everything in the header fits

  • Button disappears if PWA is unsupported (Safari, IE?) or if the user has the app already installed.

  • Added PWA store to preserve PWA install prompt (the install prompt was lost upon desktop to mobile window resize when only storing it to component state)

Test Plan

  • Ensure button prompts + installs PWA properly on both desktop and mobile
  • Ensure buttons in the header all fit on mobile view (width <400px)
  • Ensure button disappears if PWA is already installed, on both the web and PWA versions.
  • Ensure button reappears upon PWA uninstallation
  • Ensure button is hidden when user is on unsupported browser (Safari & Firefox for desktop, IE -- if anyone uses that anymore)

Issues

Closes #936

@MinhxNguyen7
Copy link
Member

Seems to work from a quick check on my phone. FYI, the check allows the button to hide after the PWA has been installed or if you're in incognito.

That being said. I think a banner, or just somewhere other than the top bar, might be better.

@KevinWu098
Copy link
Member

Seems to work from a quick check on my phone. FYI, the check allows the button to hide after the PWA has been installed or if you're in incognito.

That being said. I think a banner, or just somewhere other than the top bar, might be better.

I agree here -- we have pretty limited space in the header on smaller screen sizes. A dismissible banner (not unlike RecruitmentBanner) might be better for grabbing user attention w/o compromising on permanent screen real estate

@MinhxNguyen7
Copy link
Member

But then, we agreed that people aren't likely to install it before actually using it, so they'd just dismiss it.

How about a banner that comes back if it has been long enough? Something like a one-month delay could make sense.

@KevinWu098
Copy link
Member

Makes sense @MinhxNguyen7!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

PWA Banner
3 participants