merged the (old) shared library support into the new structure #678
Conversation
|
I am glad it worked for your ad-hoc testing. To merge this PR into main code base, we need all current tests working and new ones created for new functionality. |
|
working on fixing the tests... |
|
Is there any way to already test the shared library support ? I'm currently running the latest version without shared library support on my unraid server. |
I suppose you could test version being merged from at https://github.com/fver/icloud_photos_downloader/tree/master |
@fver Any luck with this so far? |
Slowly, all tests fail due to incompatible manually adapted VCR recordings, one by one trying to fix them with limited time available. |
|
operator mistake in last merging branch, all tests should pass now. |
src/icloudpd/base.py
Outdated
| libraries_dict = icloud.photos.libraries | ||
| library_names = libraries_dict.keys() | ||
| print(*library_names, sep="\n") | ||
| sys.exit(0) |
There was a problem hiding this comment.
Pls change to return, so program exists are only at top level
There was a problem hiding this comment.
adapted, in a separate commit - extra return triggered a lint warning, so did some refactor
|
Just stumbled upon this issue and gladly saw this PR is on it's way to master. Thanks a lot for the effort everyone. There's definitely many people who need this (and likely to increase over time). I'll do my best to test it and repot/fix any problems that I find. |
AndreyNikiforov
merged commit afd6f8a
into
icloud-photos-downloader:master
Merged the shared library support to the latest branch. All credit to the original creator @pneff of this PR.
Since file locations changed, this was not automatic but it works for me, syncing a +200k photo library, no other extensive testing done.