Add back macOS and Windows CI (#4101)

icerpc · Nov 15, 2024 · f5ad04b · f5ad04b
1 parent db92db5
commit f5ad04b
Show file tree

Hide file tree

Showing 3 changed files with 18 additions and 6 deletions.
diff --git a/.github/actions/test/action.yaml b/.github/actions/test/action.yaml
@@ -6,9 +6,11 @@ runs:
   - name: 🧪 Test Slice Compiler
     run: cargo test --manifest-path tools/slicec-cs/Cargo.toml
     shell: bash
+
   - name: 🧪 Test
     run: dotnet test --no-build --verbosity normal --blame-hang-timeout 10s
     shell: bash
+
   - name: Upload blame hang dumps
     uses: actions/upload-artifact@v4
     with:

diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml
@@ -16,7 +16,7 @@ jobs:
     strategy:
       fail-fast: false
       matrix:
-        os: [ubuntu-latest, windows-latest]
+        os: [ubuntu-latest, macos-latest, windows-latest]
     runs-on: ${{ matrix.os }}
     timeout-minutes: 15
     steps:

diff --git a/tests/IceRpc.Tests/Transports/Tcp/TcpTransportConformanceTests.cs b/tests/IceRpc.Tests/Transports/Tcp/TcpTransportConformanceTests.cs
@@ -5,6 +5,7 @@
 using NUnit.Framework;
 using System.Net;
 using System.Net.Sockets;
+using System.Runtime.InteropServices;
 
 namespace IceRpc.Tests.Transports.Tcp;
 
@@ -48,16 +49,25 @@ protected override IServiceCollection CreateServiceCollection(int? listenBacklog
 
 internal class Ipv6SupportFixture
 {
+
     public static void FixtureSetUp()
     {
-        using var socket = new Socket(AddressFamily.InterNetworkV6, SocketType.Stream, ProtocolType.Tcp);
-        try
+        // TODO: remove this if check once https://github.com/dotnet/runtime/issues/102663 makes it to 8.0
+        if (RuntimeInformation.IsOSPlatform(OSPlatform.OSX))
         {
-            socket.Bind(new IPEndPoint(IPAddress.IPv6Loopback, 0));
+            Assert.Ignore("IPv6 is not supported on macOS");
         }
-        catch
+        else
         {
-            Assert.Ignore("IPv6 is not supported on this platform");
+            using var socket = new Socket(AddressFamily.InterNetworkV6, SocketType.Stream, ProtocolType.Tcp);
+            try
+            {
+                socket.Bind(new IPEndPoint(IPAddress.IPv6Loopback, 0));
+            }
+            catch
+            {
+                Assert.Ignore("IPv6 is not supported on this platform");
+            }
         }
     }
 }