Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix alternative centroid methods #437

Merged
merged 7 commits into from
Dec 12, 2023
Merged

Fix alternative centroid methods #437

merged 7 commits into from
Dec 12, 2023

Conversation

btjanaka
Copy link
Member

@btjanaka btjanaka commented Dec 9, 2023

Description

The centroid methods in CVTArchive were not generating centroids according to the specifications, i.e., the centroids were not of the correct number, and the centroids were not within the correct bounds.

TODO

  • Write test to demonstrate bug
  • Fix methods

Status

  • I have read the guidelines in
    CONTRIBUTING.md
  • I have formatted my code using yapf
  • I have tested my code by running pytest
  • I have linted my code with pylint
  • I have added a one-line description of my change to the changelog in
    HISTORY.md
  • This PR is ready to go

@btjanaka btjanaka added the bug Something isn't working label Dec 9, 2023
@btjanaka btjanaka merged commit 6bc7027 into master Dec 12, 2023
@btjanaka btjanaka deleted the centroid-bug branch December 12, 2023 00:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants