Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add GeneticAlgorithmEmitter with Internal Operator Support #427

Merged
merged 10 commits into from
Nov 30, 2023
Merged

Add GeneticAlgorithmEmitter with Internal Operator Support #427

merged 10 commits into from
Nov 30, 2023

Conversation

svott03
Copy link
Collaborator

@svott03 svott03 commented Nov 20, 2023

Description

Add GeneticAlgorithmEmitter with Internal Operator Support

Questions

The ask function uses the same logic as the IsoLineEmitter and GaussianEmitter. Is there a better way of doing this?

Status

  • I have read the guidelines in
    CONTRIBUTING.md
  • I have formatted my code using yapf
  • I have tested my code by running pytest
  • I have linted my code with pylint
  • I have added a one-line description of my change to the changelog in
    HISTORY.md
  • This PR is ready to go

btjanaka
btjanaka requested changes Nov 27, 2023
View reviewed changes
ribs/emitters/__init__.py Outdated Show resolved Hide resolved
ribs/emitters/_genetic_algorithm_emitter.py Outdated Show resolved Hide resolved
ribs/emitters/_genetic_algorithm_emitter.py Outdated Show resolved Hide resolved
ribs/emitters/_genetic_algorithm_emitter.py Outdated Show resolved Hide resolved
ribs/emitters/_genetic_algorithm_emitter.py Outdated Show resolved Hide resolved
ribs/emitters/_genetic_algorithm_emitter.py Outdated Show resolved Hide resolved
ribs/emitters/_genetic_algorithm_emitter.py Show resolved Hide resolved
ribs/emitters/_genetic_algorithm_emitter.py Outdated Show resolved Hide resolved
btjanaka
btjanaka requested changes Nov 29, 2023
View reviewed changes
ribs/emitters/_iso_line_emitter.py Outdated Show resolved Hide resolved
ribs/emitters/operators/_gaussian.py Outdated Show resolved Hide resolved
ribs/emitters/operators/_gaussian.py Show resolved Hide resolved
ribs/emitters/operators/_iso_line.py Outdated Show resolved Hide resolved
tests/emitters/genetic_algorithm_emitter_test.py Outdated Show resolved Hide resolved
ribs/emitters/_genetic_algorithm_emitter.py Show resolved Hide resolved
ribs/emitters/_genetic_algorithm_emitter.py Outdated Show resolved Hide resolved
ribs/emitters/_genetic_algorithm_emitter.py Outdated Show resolved Hide resolved
ribs/emitters/_genetic_algorithm_emitter.py Outdated Show resolved Hide resolved
ribs/emitters/_genetic_algorithm_emitter.py Outdated Show resolved Hide resolved
btjanaka
btjanaka approved these changes Nov 30, 2023
View reviewed changes
Copy link
Member

@btjanaka btjanaka left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job @svott03! Thank you for working on this PR. Just resolve the conflict in HISTORY.md and you're good to go.

@svott03 svott03 merged commit 45daa42 into master Nov 30, 2023
18 checks passed
@svott03 svott03 deleted the genetic_algorithm_emitter branch November 30, 2023 19:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@btjanaka btjanaka btjanaka approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@svott03 @btjanaka