Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove batch name from remaining archive methods #424

Merged
merged 3 commits into from
Nov 17, 2023
Merged

Remove batch name from remaining archive methods #424

merged 3 commits into from
Nov 17, 2023

Conversation

btjanaka
Copy link
Member

@btjanaka btjanaka commented Nov 17, 2023 •
edited
Loading

Description

Continuation of #422. Note that I still use measures_batch and other batch names inside of methods themselves when it is necessary to have clarity.

TODO

  • Rename measures_batch to measures in index_of
  • Rename measures_batch to measures in retrieve

Questions

Status

  • I have read the guidelines in
    CONTRIBUTING.md
  • I have formatted my code using yapf
  • I have tested my code by running pytest
  • I have linted my code with pylint
  • I have added a one-line description of my change to the changelog in
    HISTORY.md
  • This PR is ready to go

@btjanaka btjanaka merged commit a5b5afc into master Nov 17, 2023
17 checks passed
@btjanaka btjanaka deleted the archive-args branch November 17, 2023 05:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@btjanaka