Remove metadata in favor of custom fields #420
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
We plan to add the ability to specify custom fields in pyribs archives. This PR thus removes metadata, which are a current substitute for custom fields. Custom fields will also support object dtypes, meaning metadata can still be recovered by specifying a metadata field with object dtype.
While this change is backwards-incompatible, I believe it is beneficial for the simplicity of the library. Currently, metadata is the only array that is an object array, making it more difficult to save next to arrays like the objective and measures arrays. Furthermore, metadata currently has a complex defaulting system since it is usually None.
TODO
Questions
Status
CONTRIBUTING.md
yapf
pytest
pylint
HISTORY.md