Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add centroid benchmarking #405

Merged
merged 5 commits into from
Nov 10, 2023
Merged

Add centroid benchmarking #405

merged 5 commits into from
Nov 10, 2023

Conversation

HenryChen4
Copy link
Collaborator

Description

TODO

  • TODO 1

Questions

  • Question 1

Status

  • I have read the guidelines in
    CONTRIBUTING.md
  • I have formatted my code using yapf
  • I have tested my code by running pytest
  • I have linted my code with pylint
  • I have added a one-line description of my change to the changelog in
    HISTORY.md
  • This PR is ready to go

btjanaka
btjanaka requested changes Nov 7, 2023
View reviewed changes
Copy link
Member

@btjanaka btjanaka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Requested several changes. Please make sure to fill out the description as well.

benchmarks/benchmark.py Outdated Show resolved Hide resolved
benchmarks/benchmark.py Outdated Show resolved Hide resolved
benchmarks/benchmark.py Outdated Show resolved Hide resolved
benchmarks/benchmark.py Outdated Show resolved Hide resolved
benchmarks/benchmark.py Show resolved Hide resolved
benchmarks/benchmark.py Outdated Show resolved Hide resolved
benchmarks/benchmark.py Show resolved Hide resolved
benchmarks/benchmark.py Show resolved Hide resolved
btjanaka
btjanaka approved these changes Nov 9, 2023
View reviewed changes
benchmarks/benchmark.py Outdated Show resolved Hide resolved
benchmarks/benchmark.py Outdated Show resolved Hide resolved
benchmarks/benchmark.py Outdated Show resolved Hide resolved
benchmarks/benchmark.py Outdated Show resolved Hide resolved
@btjanaka
Copy link
Member

btjanaka commented Nov 9, 2023

@HenryChen4 Thank you again for the PR! I've left some minor comments on english stuff. Make the changes, resolve the comments, and then merge the PR.

@HenryChen4 HenryChen4 merged commit 0bb298f into master Nov 10, 2023
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@btjanaka btjanaka btjanaka approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@HenryChen4 @btjanaka