Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make ArrayStore data methods more flexible #402

Merged
merged 5 commits into from
Nov 6, 2023
Merged

Make ArrayStore data methods more flexible #402

merged 5 commits into from
Nov 6, 2023

Conversation

btjanaka
Copy link
Member

@btjanaka btjanaka commented Nov 6, 2023

Description

This PR modifies ArrayStore as follows:

  • Introduces a tuple return type to the retrieve and as_dict methods
  • Renames as_dict to data()
  • Removes as_pandas() in favor of data(return_type="pandas") and retrieve(return_type="pandas")
  • Moves index to the end of return types where order matters, i.e., index is now the last column in pandas dataframes, and the last entry in tuples

TODO

Questions

Status

  • I have read the guidelines in
    CONTRIBUTING.md
  • I have formatted my code using yapf
  • I have tested my code by running pytest
  • I have linted my code with pylint
  • I have added a one-line description of my change to the changelog in
    HISTORY.md
  • This PR is ready to go

@btjanaka btjanaka merged commit 80fbd3e into master Nov 6, 2023
17 checks passed
@btjanaka btjanaka deleted the arraystore branch November 6, 2023 08:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant