Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename measure_* columns to measures_* in as_pandas #396

Merged
merged 2 commits into from
Nov 1, 2023
Merged

Rename measure_* columns to measures_* in as_pandas #396

merged 2 commits into from
Nov 1, 2023

Conversation

btjanaka
Copy link
Member

@btjanaka btjanaka commented Nov 1, 2023 •
edited
Loading

Description

In other parts of the library, fields like solution and objective are consistently plural or singular. Since the rest of the library uses measures (e.g., EliteBatch has measures_batch), this PR changes the columns in as_pandas to start with measures instead of measure.

TODO

Questions

Status

  • I have read the guidelines in
    CONTRIBUTING.md
  • I have formatted my code using yapf
  • I have tested my code by running pytest
  • I have linted my code with pylint
  • I have added a one-line description of my change to the changelog in
    HISTORY.md
  • This PR is ready to go

@btjanaka btjanaka merged commit 9484717 into master Nov 1, 2023
18 checks passed
@btjanaka btjanaka deleted the aspandas branch November 1, 2023 04:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@btjanaka