Test pyribs installation in tutorials #384
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Previously, we always installed
ribs[visualize]
before testing tutorials. This led to uncaught bugs where some tutorials neededribs[visualize]
to be installed but did not install it -- namely, since we always installedribs[visualize]
, the tutorial could get by without installingribs[visualize]
. This led to bugs such as those in #379. To remedy this issue, this PR removes the default installation ofribs[visualize]
in the tutorial CI.Instead, the notebook now installs the local copy of pyribs on its own -- we do this by replacing, e.g.,
pip install ribs[visualize]
withpip install .[visualize]
. Note that it is not possible to leave this dependency as is (i.e.,pip install ribs[visualize]
) because the tutorial would pull from PyPI instead of the local copy.TODO
Questions
Status
CONTRIBUTING.md
yapf
pytest
pylint
HISTORY.md