Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use setdefault to handle default kwargs more cleanly #360

Merged
merged 2 commits into from
Sep 7, 2023
Merged

Use setdefault to handle default kwargs more cleanly #360

merged 2 commits into from
Sep 7, 2023

Conversation

btjanaka
Copy link
Member

@btjanaka btjanaka commented Sep 7, 2023

Description

Using setdefault is shorter than checking "if X not in kwargs..."

TODO

Questions

Status

  • I have read the guidelines in
    CONTRIBUTING.md
  • I have formatted my code using yapf
  • I have tested my code by running pytest
  • I have linted my code with pylint
  • [N/A] I have added a one-line description of my change to the changelog in
    HISTORY.md
  • This PR is ready to go

@btjanaka btjanaka merged commit 847cf6e into master Sep 7, 2023
18 checks passed
@btjanaka btjanaka deleted the setdefault branch September 7, 2023 20:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@btjanaka