New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add GradientEmitter to support OMG-MEGA and OG-MAP-Elites #348

Merged

yutaizhou merged 55 commits into icaros-usc:master from yutaizhou:omg-mega/emitter

Sep 21, 2023

Contributor

yutaizhou commented Aug 25, 2023

Description

Implemented GradientEmitter from the official DQD repo, which is used to implement OMG-MEGA and OG-MAP-Elites.

TODO

ported over official DQD repo's implementation of GradientEmitter
added relevant pytests and documentation
benchmarked to achieve similar performance as the DQD paper

Questions

Status

I have read the guidelines in CONTRIBUTING.md
I have formatted my code using yapf
I have tested my code by running pytest
I have linted my code with pylint
I have added a one-line description of my change to the changelog in HISTORY.md
This PR is ready to go

yutaizhou and others added 24 commits

August 20, 2023 20:30


          swap out mp for dask

0e85f88


          add to history.md

da408da


          Replace multiprocessing text

873c834


          add dask distributed to pip install list

28e5aca


          install swig on separate line

22bbceb


          edit history.md to include swig, and clean up imports in tutorial

34f58bb


          take out dask call to LocalCluster

817f246


          Update HISTORY.md

04e919e


          Remove LocalCluster

aead9da


          Note import

15f5a70


          Revert image

dc15b4a


          Update lunar_lander.ipynb

2a48e73


          grokked the pyribs dqd interface. starting to add functions for OMG-MEGA

5f3797b


          added omg-mega to test and import, first pass at {ask/tell}_dqd()

21ef8e0


          passed sphere archive coverage test. need to debug QD score being sup…

9a733c5

…er high


          OG-MAP-Elites added

091c317


          Merge branch 'omg-mega/emitter' of github.com:yutaizhou/pyribs into o…

989cdcd

…mg-mega/emitter


          more properties to make it more 0.5 like

7a5594c


          make gradient_emitter accept initial solutions (xor x0)

73fdffc


          vectorized isolinedd added!

c758bb5


          gradient emitter test!

c2de49d


          documentation for gradient_emitter

5280e9f


          forgot history.md

ed93866


          Merge branch 'master' into omg-mega/emitter

574c018

btjanaka changed the title ~~GradientEmitter for OMG-MEGA and OG-MAP-Elites~~ Add GradientEmitter to support OMG-MEGA and OG-MAP-Elites

btjanaka requested changes

View reviewed changes

Member

btjanaka left a comment

Hi @yutaizhou, thank you for working on this implementation! I've left a couple of comments. Can you also merge the most recent master code into this branch so that you get pre-commit and all? Thanks!

HISTORY.md Outdated Show resolved Hide resolved

examples/sphere.py Show resolved Hide resolved

ribs/emitters/_gradient_emitter.py Outdated Show resolved Hide resolved

ribs/emitters/_gradient_emitter.py Outdated Show resolved Hide resolved

ribs/emitters/_gradient_emitter.py Outdated Show resolved Hide resolved

ribs/emitters/_gradient_emitter.py Outdated Show resolved Hide resolved

ribs/emitters/_gradient_emitter.py Outdated Show resolved Hide resolved

ribs/emitters/_gradient_emitter.py Outdated Show resolved Hide resolved

ribs/emitters/_gradient_emitter.py Outdated Show resolved Hide resolved

ribs/emitters/_gradient_emitter.py Outdated Show resolved Hide resolved

yutaizhou self-assigned this

yutaizhou added 3 commits

September 9, 2023 11:51


          Merge remote-tracking branch 'remotes/upstream/master' into omg-mega/…

6fd5344

…emitter


          updated HISTORY to reflect GradientEmitter

cc9fc68


          use np clip instead of max and min for noise clipping


          extended docstring added

2d3c97e

yutaizhou commented

View reviewed changes

Contributor Author

yutaizhou left a comment

mostly copy pasted from GradientArborescenceEmitter, but made the distinction that the GradientArborescence coefficients are not adaptive for GradientOperatorEmitter. let me know if that works!

ribs/emitters/_gradient_emitter.py Outdated Show resolved Hide resolved

examples/sphere.py Outdated Show resolved Hide resolved

ribs/emitters/_gradient_emitter.py Outdated Show resolved Hide resolved

examples/sphere.py Show resolved Hide resolved

btjanaka added 11 commits

September 10, 2023 04:55


          Merge branch 'master' into omg-mega/emitter

a866f1e


          history

d40d881


          Update call to validate_batch_args

9c1b575


          Make isort line length be 80 to match yapf


          Remove yapf disable

dcb7a31


          Fix pylint error in sphere.py

70c91a1


          Add period

1632a03


          Add GradientOperatorEmitter to list in emitter docs

b19d1cb


          Comment on batch size

f325be5


          Docstring edits

608132a


          fix link to tell_dqd

32f8ef7

btjanaka requested changes

View reviewed changes

Member

btjanaka left a comment

Looking good. The remaining issue is making sure that the main docstring accurately reflects how the emitter operates.

examples/sphere.py Show resolved Hide resolved

ribs/emitters/_gradient_emitter.py Outdated Show resolved Hide resolved

examples/sphere.py Outdated Show resolved Hide resolved

ribs/emitters/_gradient_emitter.py Outdated Show resolved Hide resolved

ribs/emitters/_gradient_emitter.py Outdated Show resolved Hide resolved

examples/sphere.py Show resolved Hide resolved

ribs/emitters/_gradient_operator_emitter.py Outdated Show resolved Hide resolved

ribs/emitters/_gradient_operator_emitter.py Outdated Show resolved Hide resolved

ribs/emitters/_gradient_operator_emitter.py Outdated Show resolved Hide resolved

yutaizhou added 4 commits

September 14, 2023 16:19


          no default values for sigma0 and sigma_g. also take out shape checkin…

68f36f7

…g for jacobian as it should always be 3 dim


          sigma0 to sigma, changed pytest fname to reflect new classname for gr…

51ea8c5

…adient operator emitter


          take out linebreak

5fb221c


          updated docstring for gradientOperator

ffc81c9

yutaizhou commented

View reviewed changes

Contributor Author

yutaizhou left a comment

let me know how this new docstring looks!

btjanaka added 2 commits

September 21, 2023 00:31


          Merge branch 'omg-mega/emitter' of github.com:yutaizhou/pyribs into o…

51d4339

…mg-mega/emitter


          Add see also to gradient arborescence emitter

7ce06aa

btjanaka reviewed

View reviewed changes

ribs/emitters/_gradient_operator_emitter.py Show resolved Hide resolved

btjanaka added 2 commits

September 21, 2023 00:39


          Update leading docstring

37b7ed5


          Update top line

13b008f

btjanaka approved these changes

View reviewed changes

Member

btjanaka left a comment

One minor change remaining

btjanaka added 2 commits

September 21, 2023 00:41


          Merge branch 'master' into omg-mega/emitter

1313a2f


          Move history to new version

dedeb9d

Member

btjanaka commented Sep 21, 2023

Thanks a ton for working on this PR Yutai! I left a minor comment; otherwise, this PR is good to go.


          isolinedd docstring

0a125d7

yutaizhou merged commit 52a0590 into icaros-usc:master

18 checks passed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet