Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use dask instead of multiprocessing for lunar lander tutorial (#346) #347

Merged
merged 12 commits into from
Aug 21, 2023
Merged

Use dask instead of multiprocessing for lunar lander tutorial (#346) #347

merged 12 commits into from
Aug 21, 2023

Conversation

yutaizhou
Copy link
Contributor

@yutaizhou yutaizhou commented Aug 21, 2023

Description

fixes #346

Also encountered an issue with box2d not installing properly. Thus, this PR also moves swig installation before box2d so that swig is available when box2d is being built. See Farama-Foundation/Gymnasium#662 for more info

TODO

  • test code on linux machine

Questions

Status

  • I have read the guidelines in CONTRIBUTING.md
  • I have formatted my code using yapf
  • I have tested my code by running pytest
  • I have linted my code with pylint
  • I have added a one-line description of my change to the changelog in HISTORY.md
  • This PR is ready to go

Copy link
Member

@btjanaka btjanaka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor changes; I also added a note about using dask instead of multiprocessing

HISTORY.md Outdated Show resolved Hide resolved
tutorials/lunar_lander.ipynb Outdated Show resolved Hide resolved
tutorials/lunar_lander.ipynb Outdated Show resolved Hide resolved
@btjanaka btjanaka merged commit e039862 into icaros-usc:master Aug 21, 2023
20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] Lunar Lander tutorial pool.starmap() does not accept custom functions in interactive interpreter
2 participants