Skip to content

Commit

Permalink
Add pre-commit to dev deps (#363)
Browse files Browse the repository at this point in the history
## Description

<!-- Provide a brief description of the PR's purpose here. -->

CONTRIBUTING.md was amended in #351 to state that we install pre-commit
in the dev dependencies, but we forgot to modify the dependencies in
#351.

## TODO

<!-- Notable points that this PR has either accomplished or will
accomplish. -->

## Questions

<!-- Any concerns or points of confusion? -->

## Status

- [x] I have read the guidelines in

[CONTRIBUTING.md](https://github.com/icaros-usc/pyribs/blob/master/CONTRIBUTING.md)
- [x] I have formatted my code using `yapf`
- [x] I have tested my code by running `pytest`
- [x] I have linted my code with `pylint`
- [x] I have added a one-line description of my change to the changelog
in
      `HISTORY.md`
- [x] This PR is ready to go
  • Loading branch information
btjanaka authored Sep 9, 2023
1 parent 563ea2c commit 28fbcf9
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 1 deletion.
2 changes: 1 addition & 1 deletion HISTORY.md
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@

#### Improvements

- Improve developer workflow with pre-commit ({pr}`351`)
- Improve developer workflow with pre-commit ({pr}`351`, {pr}`363`)
- Refactor visualize module into multiple files ({pr}`357`)
- Add GitHub link roles in documentation ({pr}`361`)

Expand Down
1 change: 1 addition & 0 deletions setup.py
Original file line number Diff line number Diff line change
Expand Up @@ -39,6 +39,7 @@
"pip>=20.3",
"pylint",
"yapf",
"pre-commit",

# Testing
"pytest==7.0.1",
Expand Down

0 comments on commit 28fbcf9

Please sign in to comment.