Issue135 forecast uncertainty 2 #693
Open
+4,248
−68
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ErrorEmulator.py: function to generate an error with an AR model in the prediction horizon. SimulateError.ipynb: notebook to simulate the error for different uncertainty scenarios.
The predict_error method is imported in forecaster.py.
The arguments required by "predict_error" are propagated in get_forecast: F0, K0, F, K, mu. The hp is already defined (horizon). Default values are included for these parameters for the deterministic scenario.
predict_error is updated to predict_error_AR to specify the error model
…into issue135_forecastUncertainty # Conflicts: # forecast/forecaster.py
…nario, and prevent the weather forecast uncertainty from being overwritten in get_forecast after setting it in the scenario.
…n and introduced two new tests: test_forecast_temperature_are_within_range and test_forecast_solar_radiation_are_positive for improved criteria checking.
Issue135 forecast uncertainty
…o issue135_forecastUncertainty merge laura's revise
…_forecastUncertainty_2
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A test PR instead of #482 to include changes from Wanfu.