Issue1576 heat pump model integration suggestions #1770
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is to avoid placeholder parameter assignments that are awkward and non-physical to suppress model check errors
|
Thanks for the changes! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR contains revision suggestions for PR #1628 as part of the review process, especially for the boring renaming and re-foldering under the scope of the Style Guide and the Conventions.
This PR currently does three things:
Datasubpackages and control blocks to aControlssubpackage, as is consistent with how other packages host these classes.Fluid.HeatExchangers.EvaporatorCondenserWithCapacityso that it doesn't look like a signal connector is connected to a heat port.Fluid.Chillers.BaseClasses.ChillerRefrigerantCycle, replacedreplaceable Fluid.Chillers.RefrigerantCycleModels.BaseClasses.PartialChillerRefrigerantCyclewith.NoCooling. This is to avoid the awkward placeholder parameter assignments.@FWuellhorst -
Please review and feel free to cherrypick as you see fit.