Add configure support to enable RAM class persistence #770
Conversation
|
ping @babsingh |
|
Please correct the typo in the commit message and the summary here to spell "configure" correctly. |
ThanHenderson
changed the title
Signed-off-by: Nathan Henderson <[email protected]>
|
Jenkins compile aix,osx,win,zlinux jdk8 |
|
Neither the UMA flag Why was it not first proposed for the head stream and then back-ported to earlier versions? |
| AC_MSG_RESULT([yes (explicitly enabled)]) | ||
| OPENJ9_ENABLE_SNAPSHOTS=true | ||
| elif test "x$enable_snapshots" = xno ; then | ||
| AC_MSG_RESULT([no (explicit)]) |
There was a problem hiding this comment.
Why does this not say "no (explicitly disabled)" like other options?
There was a problem hiding this comment.
You're right. This is a mistake. I will open new PR to address any concerns you have here.
| @@ -61,6 +61,7 @@ OPENJ9_ENABLE_DEMOS := @OPENJ9_ENABLE_DEMOS@ | |||
| OPENJ9_ENABLE_JFR := @OPENJ9_ENABLE_JFR@ | |||
| OPENJ9_ENABLE_JITSERVER := @OPENJ9_ENABLE_JITSERVER@ | |||
| OPENJ9_ENABLE_OPENJDK_METHODHANDLES := @OPENJ9_ENABLE_OPENJDK_METHODHANDLES@ | |||
| OPENJ9_ENABLE_SNAPSHOTS := @OPENJ9_ENABLE_SNAPSHOTS@ | |||
There was a problem hiding this comment.
Tabs should only be used for indentation (not after any non-whitespace character).
| FEATURE_SED_SCRIPT += $(call SedEnable,opt_snapshots) | ||
| FEATURE_SED_SCRIPT += $(call SedDisable,opt_snapshots) | ||
| else # OPENJ9_ENABLE_SNAPSHOTS | ||
| FEATURE_SED_SCRIPT += $(call SedEnable,opt_snashots) |
There was a problem hiding this comment.
Just noticed this is incorrect too. I had forgotten to push the most recent changes before this was merged.
It is part of a revival of an older project that was/is only currently supporting JDK8. |
|
Reference to eclipse-openj9/openj9#20387 and an explanation why it only applies to jdk8 would have been welcome pieces of information to include in the description here (although I have trouble imagining why it needs to be restricted to jdk8). |
|
Apologies, I should have linked it. It won't be restricted to JDK8, but it is only currently built/tested on JDK8. We are planning to port to new LTS JDK versions once we assess the requirements/feature support that is needed to accommodate them. |
The code to adjust |
I mean that it isn't used at all, nor specified, in the OpenJ9 patch, and we can add it later if we need. |
Adds support for setting the
J9VM_OPT_SNAPSHOTSdirective with the--enable-snapshotsconfigure option. This enables the ongoing RAMClass persistence work.Related: https://github.ibm.com/runtimes/openj9/issues/755
Signed-off-by: Nathan Henderson [email protected]