Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable JFR on all platforms #920

Open
wants to merge 1 commit into
base: openj9
Choose a base branch
from
Open

Conversation

tajila
Copy link
Member

@tajila tajila commented Jan 21, 2025

No description provided.

@tajila tajila requested a review from JasonFengJ9 January 21, 2025 18:30
@JasonFengJ9
Copy link
Member

jenkins compile amac jdknext

@JasonFengJ9
Copy link
Member

amac compilation failure:

14:36:34  /Users/jenkins/workspace/Build_JDKnext_aarch64_mac_Personal/openj9/runtime/vm/jfr.cpp:1123:35: error: result of comparison against a string literal is unspecified (use an explicit string comparison function instead) [-Werror,-Wstring-compare]
14:36:34          if ((char*)DEFAULT_JFR_FILE_NAME != vm->jfrState.jfrFileName) {
14:36:34              ~~~~~~~~~~~~~~~~~~~~~~~~~~~~ ^
14:36:34  In file included from /Users/jenkins/workspace/Build_JDKnext_aarch64_mac_Personal/openj9/runtime/vm/jfr.cpp:22:
14:36:34  In file included from /Users/jenkins/workspace/Build_JDKnext_aarch64_mac_Personal/openj9/runtime/vm/JFRConstantPoolTypes.hpp:37:
14:36:34  /Users/jenkins/workspace/Build_JDKnext_aarch64_mac_Personal/openj9/runtime/vm/BufferWriter.hpp:36:8: error: private field '_size' is not used [-Werror,-Wunused-private-field]
14:36:34          UDATA _size;
14:36:34                ^
14:36:34  2 errors generated.

@keithc-ca
Copy link
Member

jenkins compile amac jdknext

@JasonFengJ9
Copy link
Member

The compilation failure was fixed by

@JasonFengJ9
Copy link
Member

jenkins compile win jdknext

@JasonFengJ9
Copy link
Member

jenkins compile aix jdknext

@JasonFengJ9
Copy link
Member

All nodes of label ‘ci.role.build&&hw.arch.x86&&sw.os.windows’ are offline

A personal build has following warning treated as an error:

16:27:13  c:\users\jenkins\workspace\build_jdknext_x86-64_windows_personal\openj9\runtime\vm\JFRConstantPoolTypes.hpp(519): error C2220: the following warning is treated as an error
16:27:13  c:\users\jenkins\workspace\build_jdknext_x86-64_windows_personal\openj9\runtime\vm\JFRConstantPoolTypes.hpp(519): warning C4244: '=': conversion from 'UDATA' to 'I_32', possible loss of data
16:27:13  c:\users\jenkins\workspace\build_jdknext_x86-64_windows_personal\openj9\runtime\vm\JFRConstantPoolTypes.hpp(525): warning C4244: '=': conversion from 'UDATA' to 'I_32', possible loss of data
16:27:13  c:\users\jenkins\workspace\build_jdknext_x86-64_windows_personal\openj9\runtime\vm\JFRConstantPoolTypes.hpp(921): warning C4244: '+=': conversion from 'UDATA' to 'U_32', possible loss of data
16:27:13  c:\users\jenkins\workspace\build_jdknext_x86-64_windows_personal\openj9\runtime\vm\JFRConstantPoolTypes.hpp(1052): warning C4244: '=': conversion from 'uintptr_t' to 'U_32', possible loss of data
16:27:13  c:\users\jenkins\workspace\build_jdknext_x86-64_windows_personal\openj9\runtime\vm\JFRConstantPoolTypes.hpp(1057): warning C4244: '=': conversion from 'uintptr_t' to 'U_32', possible loss of data
16:27:13  c:\users\jenkins\workspace\build_jdknext_x86-64_windows_personal\openj9\runtime\vm\JFRChunkWriter.hpp(241): warning C4477: 'snprintf' : format string '%lX' requires an argument of type 'unsigned long', but variadic argument 2 has type 'UDATA'
16:27:13  c:\users\jenkins\workspace\build_jdknext_x86-64_windows_personal\openj9\runtime\vm\JFRChunkWriter.hpp(241): note: consider using '%llX' in the format string
16:27:13  c:\users\jenkins\workspace\build_jdknext_x86-64_windows_personal\openj9\runtime\vm\JFRChunkWriter.hpp(241): note: consider using '%IX' in the format string
16:27:13  c:\users\jenkins\workspace\build_jdknext_x86-64_windows_personal\openj9\runtime\vm\JFRChunkWriter.hpp(241): note: consider using '%I64X' in the format string
16:27:13  c:\users\jenkins\workspace\build_jdknext_x86-64_windows_personal\openj9\runtime\vm\JFRChunkWriter.hpp(422): warning C4244: 'argument': conversion from '__int64' to 'U_32', possible loss of data
16:27:13  c:\users\jenkins\workspace\build_jdknext_x86-64_windows_personal\openj9\runtime\vm\JFRChunkWriter.hpp(453): warning C4244: 'argument': conversion from '__int64' to 'U_32', possible loss of data
16:27:13  c:\users\jenkins\workspace\build_jdknext_x86-64_windows_personal\openj9\runtime\vm\JFRChunkWriter.hpp(478): warning C4244: 'argument': conversion from '__int64' to 'U_32', possible loss of data
16:27:13  c:\users\jenkins\workspace\build_jdknext_x86-64_windows_personal\openj9\runtime\vm\JFRChunkWriter.hpp(511): warning C4244: 'argument': conversion from '__int64' to 'U_32', possible loss of data
16:27:13  c:\users\jenkins\workspace\build_jdknext_x86-64_windows_personal\openj9\runtime\vm\JFRChunkWriter.hpp(556): warning C4244: 'argument': conversion from '__int64' to 'U_32', possible loss of data
16:27:13  c:\users\jenkins\workspace\build_jdknext_x86-64_windows_personal\openj9\runtime\vm\JFRChunkWriter.hpp(598): warning C4244: 'argument': conversion from '__int64' to 'U_32', possible loss of data
16:27:13  c:\users\jenkins\workspace\build_jdknext_x86-64_windows_personal\openj9\runtime\vm\JFRChunkWriter.hpp(627): warning C4244: 'argument': conversion from '__int64' to 'U_32', possible loss of data
16:27:13  c:\users\jenkins\workspace\build_jdknext_x86-64_windows_personal\openj9\runtime\vm\JFRChunkWriter.hpp(655): warning C4244: 'argument': conversion from '__int64' to 'U_32', possible loss of data
16:27:13  c:\users\jenkins\workspace\build_jdknext_x86-64_windows_personal\openj9\runtime\vm\jfr.cpp(965): warning C4244: '=': conversion from 'double' to 'float', possible loss of data
16:27:13  c:\users\jenkins\workspace\build_jdknext_x86-64_windows_personal\openj9\runtime\vm\jfr.cpp(966): warning C4244: '=': conversion from 'double' to 'float', possible loss of data
16:27:13  c:\users\jenkins\workspace\build_jdknext_x86-64_windows_personal\openj9\runtime\vm\jfr.cpp(974): warning C4244: '=': conversion from 'double' to 'float', possible loss of data
16:27:13  c:\users\jenkins\workspace\build_jdknext_x86-64_windows_personal\openj9\runtime\vm\jfr.cpp(1004): warning C4244: '=': conversion from 'double' to 'float', possible loss of data
16:27:13  c:\users\jenkins\workspace\build_jdknext_x86-64_windows_personal\openj9\runtime\vm\jfr.cpp(1005): warning C4244: '=': conversion from 'double' to 'float', possible loss of data
16:27:13  make[6]: *** [runtime/vm/CMakeFiles/j9vm.dir/build.make:1621: runtime/vm/CMakeFiles/j9vm.dir/jfr.cpp.obj] Error 2
16:27:13  make[6]: *** Waiting for unfinished jobs....
16:27:13  c:\users\jenkins\workspace\build_jdknext_x86-64_windows_personal\openj9\runtime\vm\JFRConstantPoolTypes.hpp(519): error C2220: the following warning is treated as an error
16:27:13  c:\users\jenkins\workspace\build_jdknext_x86-64_windows_personal\openj9\runtime\vm\JFRConstantPoolTypes.hpp(519): warning C4244: '=': conversion from 'UDATA' to 'I_32', possible loss of data
16:27:13  c:\users\jenkins\workspace\build_jdknext_x86-64_windows_personal\openj9\runtime\vm\JFRConstantPoolTypes.hpp(525): warning C4244: '=': conversion from 'UDATA' to 'I_32', possible loss of data
16:27:13  c:\users\jenkins\workspace\build_jdknext_x86-64_windows_personal\openj9\runtime\vm\JFRConstantPoolTypes.hpp(921): warning C4244: '+=': conversion from 'UDATA' to 'U_32', possible loss of data
16:27:13  c:\users\jenkins\workspace\build_jdknext_x86-64_windows_personal\openj9\runtime\vm\JFRConstantPoolTypes.hpp(1052): warning C4244: '=': conversion from 'uintptr_t' to 'U_32', possible loss of data
16:27:13  c:\users\jenkins\workspace\build_jdknext_x86-64_windows_personal\openj9\runtime\vm\JFRConstantPoolTypes.hpp(1057): warning C4244: '=': conversion from 'uintptr_t' to 'U_32', possible loss of data
16:27:13  c:\users\jenkins\workspace\build_jdknext_x86-64_windows_personal\openj9\runtime\vm\JFRConstantPoolTypes.cpp(512): warning C4244: '=': conversion from 'UDATA' to 'U_32', possible loss of data
16:27:13  c:\users\jenkins\workspace\build_jdknext_x86-64_windows_personal\openj9\runtime\vm\JFRConstantPoolTypes.cpp(965): warning C4244: '=': conversion from 'UDATA' to 'U_32', possible loss of data
16:27:13  c:\users\jenkins\workspace\build_jdknext_x86-64_windows_personal\openj9\runtime\vm\JFRConstantPoolTypes.cpp(997): warning C4244: '=': conversion from 'UDATA' to 'U_32', possible loss of data
16:27:13  c:\users\jenkins\workspace\build_jdknext_x86-64_windows_personal\openj9\runtime\vm\JFRConstantPoolTypes.cpp(1023): warning C4244: '=': conversion from 'UDATA' to 'U_32', possible loss of data
16:27:13  c:\users\jenkins\workspace\build_jdknext_x86-64_windows_personal\openj9\runtime\vm\JFRConstantPoolTypes.cpp(1054): warning C4244: '=': conversion from 'UDATA' to 'U_32', possible loss of data
16:27:13  c:\users\jenkins\workspace\build_jdknext_x86-64_windows_personal\openj9\runtime\vm\JFRConstantPoolTypes.cpp(1092): warning C4244: '=': conversion from 'UDATA' to 'U_32', possible loss of data
16:27:13  c:\users\jenkins\workspace\build_jdknext_x86-64_windows_personal\openj9\runtime\vm\JFRConstantPoolTypes.cpp(1151): warning C4244: '=': conversion from 'UDATA' to 'U_32', possible loss of data
16:27:13  c:\users\jenkins\workspace\build_jdknext_x86-64_windows_personal\openj9\runtime\vm\JFRConstantPoolTypes.cpp(1178): warning C4244: '=': conversion from 'UDATA' to 'U_32', possible loss of data
16:27:13  c:\users\jenkins\workspace\build_jdknext_x86-64_windows_personal\openj9\runtime\vm\JFRConstantPoolTypes.cpp(1200): warning C4244: '=': conversion from 'UDATA' to 'U_32', possible loss of data
16:27:13  make[6]: *** [runtime/vm/CMakeFiles/j9vm.dir/build.make:1635: runtime/vm/CMakeFiles/j9vm.dir/JFRConstantPoolTypes.cpp.obj] Error 2

@keithc-ca
Copy link
Member

Perhaps this needs to wait for eclipse-openj9/openj9#20158?

@JasonFengJ9
Copy link
Member

Perhaps this needs to wait for eclipse-openj9/openj9#20158?

Yeah, the PR stated To avoid build failure on Windows with JFR enabled.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants