Log failed itin checks and bus notifs #263
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JymDyerIBI
approved these changes
Oct 21, 2024
br648
reviewed
Oct 22, 2024
| @@ -301,7 +302,9 @@ private boolean makeOTPRequestAndUpdateMatchingItineraryInternal() { | |||
| } | |||
|
|
|||
| // If this point is reached, a matching itinerary was not found | |||
| LOG.warn("No comparison itinerary found in otp response for trip"); | |||
| LOG.warn("No comparison itinerary found in otp response for trip - params: {}", JsonUtils.toJson(this.trip.otp2QueryParams)); | |||
| @@ -301,7 +302,9 @@ private boolean makeOTPRequestAndUpdateMatchingItineraryInternal() { | |||
| } | |||
|
|
|||
| // If this point is reached, a matching itinerary was not found | |||
| LOG.warn("No comparison itinerary found in otp response for trip"); | |||
| LOG.warn("No comparison itinerary found in otp response for trip - params: {}", JsonUtils.toJson(this.trip.otp2QueryParams)); | |||
| LOG.warn("No comparison itinerary found in otp response for trip - saved itinerary: {}", JsonUtils.toJson(this.trip.itinerary)); | |||
| LOG.warn("No comparison itinerary found in otp response for trip"); | ||
| LOG.warn("No comparison itinerary found in otp response for trip - params: {}", JsonUtils.toJson(this.trip.otp2QueryParams)); | ||
| LOG.warn("No comparison itinerary found in otp response for trip - saved itinerary: {}", JsonUtils.toJson(this.trip.itinerary)); | ||
| LOG.warn("No comparison itinerary found in otp response for trip - OTP itineraries: {}", JsonUtils.toJson(otpResponse.plan.itineraries)); |
There was a problem hiding this comment.
Should this guard against a NPE in case plan is null?
|
I am also going to add logging for when an itinerary check fails on POSTing a monitored trip. |
binh-dam-ibigroup
changed the title
3 tasks
JymDyerIBI
approved these changes
Oct 24, 2024
binh-dam-ibigroup
changed the title
br648
approved these changes
Nov 5, 2024
| // (The matching itinerary will replace the original trip.itinerary.) | ||
| if ( | ||
| ItineraryUtils.occursOnSameServiceDay(itineraryCandidate, otpRequest.dateTime, tripIsArriveBy) && | ||
| ItineraryUtils.itinerariesMatch(referenceItinerary, itineraryCandidate) |
| // If no match was found for the date, mark day of week as non-existent for the itinerary. | ||
| result.handleInvalidDate(otpRequest.dateTime); | ||
|
|
||
| // Log if the itinerary didn't exist "today" |
|
|
||
| // Log if the itinerary didn't exist "today" | ||
| if (index == 1) { | ||
| LOG.warn("Itinerary existence check failed 'today' for trip {} - params: {}", trip.id, JsonUtils.toJson(trip.otp2QueryParams)); |
There was a problem hiding this comment.
Nit. Could this be done in one warning? If not, could Itinerary existence check failed 'today' for trip be put into a separate String and reused?
| @@ -301,7 +305,9 @@ private boolean makeOTPRequestAndUpdateMatchingItineraryInternal() { | |||
| } | |||
|
|
|||
| // If this point is reached, a matching itinerary was not found | |||
| LOG.warn("No comparison itinerary found in otp response for trip"); | |||
| LOG.warn("No comparison itinerary found for trip {} - params: {}", trip.id, JsonUtils.toJson(trip.otp2QueryParams)); | |||
There was a problem hiding this comment.
Nit. Similar comment to above.
There was a problem hiding this comment.
Or perhap create a method to control the logging which is called from both places.
There was a problem hiding this comment.
@binh-dam-ibigroup Looks good now. Thanks.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
devbefore they can be merged tomaster)Description
This PR adds logging to track data sent for trip monitoring to OTP and for bus notifications to respective services.