kubernetes/controller: simplify controller registration

iawia002 · Feb 4, 2024 · b907dd5 · b907dd5
1 parent 4fc66f1
commit b907dd5
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 6 deletions.
diff --git a/kubernetes/controller/controller-runtime/controller-runtime.go b/kubernetes/controller/controller-runtime/controller-runtime.go
@@ -43,6 +43,11 @@ func (r *NodeReconciler) SetupWithManager(mgr ctrl.Manager) error {
 	r.Client = mgr.GetClient()
 	r.recorder = mgr.GetEventRecorderFor(controllerName)
 
+	// Register timed tasker
+	if err := mgr.Add(r); err != nil {
+		return err
+	}
+
 	return builder.
 		ControllerManagedBy(mgr).
 		For( // For is required, Owns and Watches are optional

diff --git a/kubernetes/controller/main.go b/kubernetes/controller/main.go
@@ -83,12 +83,7 @@ func run(config *rest.Config) error {
 		return err
 	}
 
-	nodeReconciler := &controllerruntime.NodeReconciler{}
-	if err = nodeReconciler.SetupWithManager(mgr); err != nil {
-		return err
-	}
-	// Register timed tasker
-	if err = mgr.Add(nodeReconciler); err != nil {
+	if err = (&controllerruntime.NodeReconciler{}).SetupWithManager(mgr); err != nil {
 		return err
 	}