Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: chromium interrupt IME when moving cursor #5736

Merged

Conversation

WindRunnerMax
Copy link
Contributor

Description
I found an issue in Chromium: when a node (A) is set to contenteditable=false and is followed by a text node (B), activating the IME between A and B and then holding the left arrow key to adjust input causes the IME to disappear and leads to unexpected state issues, such as composition events.

This problem does not occur in Firefox and Safari, only in browsers with the Chromium engine.

This issue is also mentioned in #3490 (comment).

Issue
Fixes: #3490 (comment)

Example
The current issues.

After making adjustments.

Context
Here's the minimal demo for this issue: when you activate the IME before the "!" character and then hold the left arrow key, the input method gets interrupted and disappears.

<div contenteditable="true"><span contenteditable="false" style="background: #eee;">Void</span><span>!</span></div>

To fix this issue, you need to create the following DOM structure. The key is that the outer span tag has a display:inline-block style, and the child div tag has a contenteditable=false attribute. This is magic.

<div contenteditable="true"><span contenteditable="false" style="background: #eee; display: inline-block;"><div contenteditable="false">Void</div></span><span>!</span></div>

Checks

  • The new code matches the existing patterns and styles.
  • The tests pass with yarn test.
  • The linter passes with yarn lint. (Fix errors with yarn fix.)
  • The relevant examples still work. (Run examples with yarn start.)
  • You've added a changeset if changing functionality. (Add one with yarn changeset add.)

Copy link

changeset-bot bot commented Oct 8, 2024

⚠️ No Changeset found

Latest commit: f18a43f

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@WindRunnerMax WindRunnerMax changed the title fix: chromium interrupt ime fix: chromium interrupt IME when moving cursor Oct 8, 2024
@dylans
Copy link
Collaborator

dylans commented Oct 8, 2024

Thanks @WindRunnerMax !

@dylans dylans merged commit 8c7f7ea into ianstormtaylor:main Oct 8, 2024
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cannot input chinese directly after the mention in mention demo
2 participants