fix: chromium interrupt IME when moving cursor #5736
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
I found an issue in Chromium: when a node (A) is set to contenteditable=false and is followed by a text node (B), activating the IME between A and B and then holding the left arrow key to adjust input causes the IME to disappear and leads to unexpected state issues, such as composition events.
This problem does not occur in Firefox and Safari, only in browsers with the Chromium engine.
This issue is also mentioned in #3490 (comment).
Issue
Fixes: #3490 (comment)
Example
The current issues.
After making adjustments.
Context
Here's the minimal demo for this issue: when you activate the IME before the "!" character and then hold the left arrow key, the input method gets interrupted and disappears.
To fix this issue, you need to create the following DOM structure. The key is that the outer span tag has a display:inline-block style, and the child div tag has a contenteditable=false attribute. This is magic.
Checks
yarn test
.yarn lint
. (Fix errors withyarn fix
.)yarn start
.)yarn changeset add
.)