Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

move @types/ dependencies to devDependencies #5683

Merged
merged 1 commit into from
Aug 7, 2024

Conversation

todor-a
Copy link
Contributor

@todor-a todor-a commented Jul 17, 2024

Description
I was exploring a dependency graph and noticed that slate-react was depending on two @types packages.

Checks

  • The new code matches the existing patterns and styles.
  • The tests pass with yarn test.
  • The linter passes with yarn lint. (Fix errors with yarn fix.)
  • The relevant examples still work. (Run examples with yarn start.)
  • You've added a changeset if changing functionality. (Add one with yarn changeset add.)

Copy link

changeset-bot bot commented Jul 17, 2024

⚠️ No Changeset found

Latest commit: 2306207

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@todor-a
Copy link
Contributor Author

todor-a commented Aug 2, 2024

@dylans not sure if I should be able to merge this but I can't.

@dylans dylans merged commit af21468 into ianstormtaylor:main Aug 7, 2024
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants