feat: Forward ref from <Editable /> #5681
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 75f9548 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
yf-yang
commented
Jul 14, 2024
| @@ -8,6 +8,7 @@ import React, { | |||
| useReducer, | |||
| useRef, | |||
| useState, | |||
| ForwardedRef, | |||
| [] | ||
| ) | ||
| export const Editable = React.forwardRef( | ||
| (props: EditableProps, forwardedRef: ForwardedRef<HTMLDivElement>) => { |
There was a problem hiding this comment.
Converts to forwardRef
| } else if (forwardedRef) { | ||
| forwardedRef.current = node | ||
| } | ||
| }, |
There was a problem hiding this comment.
Forward the ref in the callbackRef
| scheduleOnDOMSelectionChange, | ||
| editor, | ||
| onDOMBeforeInput, | ||
| forwardedRef, |
There was a problem hiding this comment.
add forwardedRef to the dependency array
|
🤔 Any hints of the broken workflow? I can execute yarn build locally. |
for some reason the website is failing to build... I'll look asap. |
dylans
approved these changes
Aug 7, 2024
Merged
This was referenced Sep 3, 2024
This was referenced Sep 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Forward ref from
<Editable />Issue
Fixes: #4082 udecode/plate#3362
Checks
yarn test.yarn lint. (Fix errors withyarn fix.)yarn start.)yarn changeset add.)