Fix ReactEditor.focus triggering onValueChange unexpectedly #5679
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #5672
Fix the issue where
ReactEditor.focus
triggersonValueChange
unexpectedly.ReactEditor.focus
inpackages/slate-react/src/plugin/react-editor.ts
to set the editor's selection without triggeringonValueChange
.onContextChange
function inpackages/slate-react/src/components/slate.tsx
to callonValueChange
only for operations that modify the editor's children.packages/slate-react/test/react-editor.spec.tsx
to ensureReactEditor.focus
does not triggeronValueChange
.For more details, open the Copilot Workspace session.