Fix contenteditalbe firefox table selection #5491
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes the contenteditable table selection in firefox. Firefox uses a custom editor when table is contenteditable and this adds support for this custom editor.
Issue
Fixes: None, but it does fix this
Example
2023-07-30.08-34-11.mp4
Before this PR it threw some exception IIRC
Context
Firefox basically uses rows in the contenteditable table selection and
startOffset
is the cell offset. By walking down the DOM tree we can get the sames values as in chrome. I also added some checks to make sure this does not crash.Checks
yarn test
.yarn lint
. (Fix errors withyarn fix
.)yarn start
.)yarn changeset add
.)