Fixed large Margin

[Noothan-am]

Description
solves large space when we press Enter

Issue
Fixes: #5457

ScreenShot

Checks

• The new code matches the existing patterns and styles.
• The tests pass with yarn test.
• The linter passes with yarn lint. (Fix errors with yarn fix.)
• The relevant examples still work. (Run examples with yarn start.)

[changeset-bot]

⚠️ No Changeset found

Latest commit: a5f8ffd

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

[dylans]

I think a better approach for this and a few other things would be to make them configurable, or provide documentation to make it clear how to override them.

Not sure why this edit removed spaces in CSS and a commented out value isn't really a final solution.

[Noothan-am]

I think a better approach for this and a few other things would be to make them configurable, or provide documentation to make it clear how to override them.

Not sure why this edit removed spaces in CSS and a commented out value isn't really a final solution.

Hey @dylans, when we click enter, the margin used to get added, so I wanted to remove that space by commenting out the CSS responsible for this issue margin-top: 1em. The spaces in the CSS code are because of my code formatter that is not the actual change I made. I have only changed the margin-top by commenting it out. Should I remove this comment and add the feature discussed earlier?

[dylans]

Hey @dylans, when we click enter, the margin used to get added, so I wanted to remove that space by commenting out the CSS responsible for this issue margin-top: 1em. The spaces in the CSS code are because of my code formatter that is not the actual change I made. I have only changed the margin-top by commenting it out. Should I remove this comment and add the feature discussed earlier?

Apologies for the slow reply, I've been traveling.

I would remove the comment. In general we need a better way to specify/override stylistic behaviors, so maybe this can be the start of that.

[dylans]

ok, I can land this once a changeset gets added and the linting issue are resolved.

[ApplyBoardDak]

why this change?

[ApplyBoardDak]

same question here

[dylans]

@Noothan-am do you have plans to address the feedback or should I close this PR?