[Draft] Avoid TextString
unmounting when rendering zero-width strings and line breaks
#5330
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This is a draft PR to refactor how zero-width strings and line breaks are rendered in the leaf
<String />
component. Currently, we conditionally render either the<TextString>
component, or the<ZeroWidthString>
component, which both ultimately render<span>
elements to the DOM.When we switch from rendering a
<TextString>
component to a<ZeroWidthString>
component, React needs to first unmount the<TextString>
component, which removes the text<span>
from the DOM, and insert a new span when the<ZeroWidthString>
component mounts.This is wasteful from a performance point of view, and can also interrupt composition events on Android.
Checks
yarn test
.yarn lint
. (Fix errors withyarn fix
.)yarn start
.)yarn changeset add
.)