-
Notifications
You must be signed in to change notification settings - Fork 3.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add unit:offset tests. #5269
base: main
Are you sure you want to change the base?
Add unit:offset tests. #5269
Conversation
|
@dylans could i get some help running the workflows? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@boweiliu Thanks, always appreciate good quality tests getting added! It looks like you just need to run Prettier on your PR and then we should be ready to land it.
@boweiliu A reminder of my previous note: Thanks, always appreciate good quality tests getting added! It looks like you just need to run Prettier on your PR and then we should be ready to land it. |
@boweiliu quick reminder, run prettier on this and then we can land it. |
Description
Adds some unit tests for the
unit: offset
behavior.Issue
Fixes: (link to issue)
Example
A GIF or video showing the old and new behaviors after this pull request is merged. Or a code sample showing the usage of a new API. (If you don't include this, your pull request will not be reviewed as quickly, because it's much too hard to figure out exactly what is going wrong, and it makes maintenance much harder.)
Context
If your change is non-trivial, please include a description of how the new logic works, and why you decided to solve it the way you did. (This is incredibly helpful so that reviewers don't have to guess your intentions based on the code, and without it your pull request will likely not be reviewed as quickly.)
Checks
yarn test
.yarn lint
. (Fix errors withyarn fix
.)yarn start
.)yarn changeset add
.)