Update editable.tsx: auto-focus fix for end of line with several chil… #4695
Conversation
…dren for input div Update editable.tsx: auto-focus fix for end of line with several children for input div
|
| if (ref.current && autoFocus) { | ||
| if(window.getSelection && document.createRange) { | ||
| const range = document.createRange(); | ||
| node.focus(); |
There was a problem hiding this comment.
@akonsu Sorry, node was a reference to ref.current in my other sandbox. Will correct it now.
| if (ref.current && autoFocus) { | ||
| if(window.getSelection && document.createRange) { | ||
| const range = document.createRange(); | ||
| ref.current.focus(); |
There was a problem hiding this comment.
Is it essential to call ref.current.focus() here and not at the end of this if clause? Maybe we can move this call out of the if statement (from both this clause and the else clause)?
| } | ||
| }, [autoFocus]) | ||
| if (ref.current && autoFocus) { | ||
| if(window.getSelection && document.createRange) { |
There was a problem hiding this comment.
Please prettify the diff. This if needs a space after it.
|
@GrinchakAndrew any chance you have time to wrap this one up. It looks like it needs a linting fix and there are a couple of comments to address. Thanks! |
Hello, i am |
Unfortunately because you created your PR from your main branch it's not easy to clone your PR locally. But I'll make it work. |
* Run prettier * Null checks for selection
|
Andrew lives in Ukraine so I know he won't be able to finish this anytime soon. We discovered this issue on a project together so I'll get this to the finish line. Looks like |
Hi @JustinBeaudry, thanks, I hope @GrinchakAndrew is ok. With respect to running locally, they run for me with 14.15.5 on macOS, but there's nothing special about that version. If they won't run locally you can commit to the PR which will trigger a re-run which is not ideal but better than nothing. Feel free to ping me on Slack ( https://join.slack.com/t/slate-js/shared_invite/zt-f8t986ip-7dA1DyiqPpzootz1snKXkw ) if you're stuck. |
|
My attempt at using GitHub's tooling to resolve merge conflicts failed badly here. I will look at this later. |
Solution resolves cursor position in the Editor with autofocus set to true, when cursor pos is 0 instead of end of line.