Change container element to a div instead of span since span can not have all elements as children according to W3C #17
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…have all elements as children according to W3C
|
This of course creates the problem in the other direction: now the |
|
@yn5 What do you think about having the container element as a prop? I feel like it should be |
|
@frostney Sounds like a good solution to me! I've added another commit to implement it. |
|
@frostney What do you think of the code? |
|
@frostney I noticed the PR caused a warning, added another commit to fix that. |
…is a span or div)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
W3C threw me an error when having a
<p>element insidereact-typewriterso I'd like to propose to change the container to be a<div>since it may have any element as a child.