-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
remove jquery dependency #47
base: unstable
Are you sure you want to change the base?
Conversation
@marfyl Thanks for the PR. I checked some other extensions we developed and it seems that we generally prefer tabWidth: 2. Can you also change it for this PR as tabWidth: 2? |
done! I just pushed the changes, thanks for the review. |
@marfyl Thanks for the changes. I reviewed the PR and it seems generally ok, but I noticed a bug in your version that doesn't exist in our version. You can see that in the below video I generated using undoable demo. Can you please check the cause of the problem? node-editing-bug.mp4 |
fixed, please refresh the cache to avoid problems |
Do you need anything else from my side to bring out a new product release? Anything else you need just let me know |
@marfyl Sorry for the late response. Your last commit fixed the error that I mentioned, but I now realized another bug during undo-redo operation. It is as follows: master_branch.mp4Behaviour in PR (nodes don't return to their original positions): PR_branch.mp4 |
Each file was formatted in a different way and cytoscape-node-editing.js file use several criterias at the same time, so I use the criteria shown above, since it were the most used inside the file. (If you want another criteria I can change it)
I think that in the future it would be good to add a .editorconfig file or .prettierrc.js file to maintain consistent coding styles for multiple developers working on the same project across various editors and IDEs. (I could add one if you want)
I hope this PR will help, anything let me know.