Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

modifications: #57

Closed
wants to merge 2 commits into from
Closed

modifications: #57

wants to merge 2 commits into from

Conversation

leoluKL
Copy link

@leoluKL leoluKL commented May 18, 2021

  • stick anchor point to 0 45 or 90 angle refer to prev or next anchor (one small defect from previous implementation is fixed)
  • add option to keep anchor point size the same no matter zoom level
  • add option to disable removing anchor because of it is in a mid of line
    -add option to disable drag edge to add bend point

Leo Lu added 2 commits May 18, 2021 10:22
- stick anchor point to 0 45 or 90 angle refer to prev or next anchro
- add option to keep anchor point size the same no matter zoom level
- add option to disable removing anchor because of it is in a mid of line
-add option to disable drag edge to add bend point
@canbax
Copy link
Member

canbax commented Nov 3, 2021

Why is the bend point dangling here? Also, I expect to see an option for this "fixed bend point" feature. It is not mentioned in your comments also.

mrn4lAXMNB.mp4

@canbax
Copy link
Member

canbax commented Nov 4, 2021

Hi @leolumicrosoft Based on your pull request we added 2 new options in d2bcd82

For

-add option to disable drag edge to add bend point

We already have option enableCreateAnchorOnDrag. If you disable it, it won't create anchors when dragging from an edge.

For the others, we think it might complicate code too much since we also plan to add support #17

Thank you!

@hasanbalci
Copy link
Contributor

I'm closing this PR, thanks @leolumicrosoft for your contributions.

@hasanbalci hasanbalci closed this Nov 16, 2021
@mike-kelly
Copy link

I am also keen to have the 'stick anchor point to 0 45 or 90 angle refer to prev or next anchor' feature, which I think is different from #17

It could also be described as a 'snap-to-grid' type functionality.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants