Fixed Player Closed in Events

[dschwartz783]

Description

Fixes #1828 and partially fixes #1865

Reason to modify

Because #1828 needed to be fixed...

Tests & Reviews

Definitely fixes #1828

[SOF3]

This only addresses one of the almost infinite problems referred to in #1865. There are PlayerLoginEvent, PlayerJoinEvent, PlayerInteractEvent, EntityDamageEvent, blah blah blah...

[dktapps]

I believe this mainly targets #1828 actually.

[SOF3]

@dktapps According to my tests with a slightly-modified Specter plugin and the script plugin provided in #1865, the output is like this:

$ s s 1dum
2016-09-05 [18:22:01] [Server thread/DEBUG]: Attempted to drop a null crafting inventory
2016-09-05 [18:22:01] [Server thread/INFO]: 1dum[/SPECTER:19133] logged out due to generic reason
2016-09-05 [18:22:01] [Server thread/INFO]: 1dum[/SPECTER:19133] [ClientID: 1] logged in with entity id 1 at (world, 0, 0, 0)
2016-09-05 [18:22:01] [Server thread/INFO]: Session started.
$ list
2016-09-05 [18:22:07] [Server thread/INFO]: There are 0/20 players online:
2016-09-05 [18:22:07] [Server thread/INFO]:

(obviously I added the $ signs)

Therefore I believe that #1828 isn't related to this pull request.

[dschwartz783]

Actually, #1865 only mentions PlayerLoginEvent in the description. This is for PlayerPreLoginEvent. I suppose it isn't really related...

[SOF3]

@dschwartz783 sorry, my wrong. I edited the issue.

[dschwartz783]

Hmm, you're right @dktapps. This does indeed fix that issue too.

[dktapps]

@SOF3 If you read #1828, his server says 30 players online when it's actually full. That's what I was referring to. I believe this is the bug that causes it.

[dktapps]

This looks fine. +1

[Muqsit]

+1