Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mslogin and login on register #514

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

jeff-zimmerman
Copy link
Contributor

Added option LOGIN_ON_REGISTER (Default: False) to app_settings.py. Modified RegisterView in registration/views.py to include the option for logging in on registration. This could not be done in user code, as there is no option to subclass the Register view (only the Register serializer). It uses basically the same code as the Login view with some slight variations.

Also added social serializer for Microsoft Graph API. This can be done user side, but I though you might like to add it as a default. It subclasses SocialLoginSerializer and implements the TwitterLoginSerializer's validation scheme. This was necessary because the standard SocialLoginSerializer uses 'access_token' and 'code' to make OAuth requests, while Microsoft uses 'accessToken' (no code). Also removed the request.session setting in validate().

@jeff-zimmerman
Copy link
Contributor Author

This passes/fails all the same tests that the main branch does.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant