Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use poco-chain with poco v5.5.0 and voucher v1.0.0 in tests #106

Open
wants to merge 7 commits into
base: develop
Choose a base branch
from

Conversation

nabil-Tounarti
Copy link

No description provided.

@nabil-Tounarti nabil-Tounarti self-assigned this Oct 22, 2024
@nabil-Tounarti nabil-Tounarti changed the title se poco-chain with poco v5.5.0 and voucher v1.0.0 in tests Use poco-chain with poco v5.5.0 and voucher v1.0.0 in tests Oct 23, 2024
@nabil-Tounarti nabil-Tounarti marked this pull request as draft October 23, 2024 12:05
@nabil-Tounarti nabil-Tounarti marked this pull request as ready for review October 23, 2024 12:05
@nabil-Tounarti nabil-Tounarti marked this pull request as draft October 23, 2024 12:11
@nabil-Tounarti nabil-Tounarti marked this pull request as ready for review October 23, 2024 12:50
CHANGELOG.md Outdated Show resolved Hide resolved
CHANGELOG.md Outdated
@@ -30,6 +30,7 @@ All notable changes to this project will be documented in this file.
- Restrict several methods visibility in `IexecHubAbstractService`. (#96)
- Avoid exceptions during `IexecHubAbstractService` and `Web3jAbstractService` objects creation. (#99)
- Improve `SignatureUtils`: remove dead code and remove cleanly unused parameter in `hashAndSign`. (#100)
- Use `poco-chain` with `poco v5.5.0` and `voucher v1.0.0` in tests (#106)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
- Use `poco-chain` with `poco v5.5.0` and `voucher v1.0.0` in tests (#106)
- Use `poco-chain` with `poco v5.5.0` and `voucher v1.0.0` in tests. (#106)

Copy link

sonarcloud bot commented Oct 25, 2024

Copy link
Contributor

@jbern0rd jbern0rd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants