Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: post-launch qa updates 2 #163

Merged
merged 8 commits into from
Jan 7, 2025
Merged

feat: post-launch qa updates 2 #163

merged 8 commits into from
Jan 7, 2025

Conversation

PetrBulanek
Copy link
Contributor

@PetrBulanek PetrBulanek commented Dec 20, 2024

Resolves:

  • [App builder] Add disabled share button to app with tooltip “Save to share”
  • [Sharing modal] Description content: “Anyone with this link can save or copy to edit this artifact” (removing the term “remix”)
  • [Apps builder] Chat side - The input/prompt section cuts off the the helper text
  • [Global Nav] Use selected style (cool-gray-10 background) for Tools and Knowledge items on the left bar nav.
  • [Global Nav] On the left nav, can we use Cool gray 10 for the section separators
  • [Global Nav] Some hovers are using gray 10 instead of cool gray 10. For example “Add new tool” button, the hamburger menu hover. Use cool gray always
  • [Usage limit modal] For the “You’ve hit your usage limit” modal, we can just remove the CTA “Ok”.
  • [Agent Builder] When I create a new agent from template and press save, a new agent from scratch is automatically loaded (the agent from template is also created as you can see it populate in the lefthand side mdenu).
  • [App library - empty state] Replace static bee illustration with blinking/wings shaking bee. Animation file here. Figma prototype
  • [Error page] We have a new illustration for “We couldn’t find the app you were looking for” here

@PetrBulanek PetrBulanek requested a review from kapetr December 20, 2024 10:25
@PetrBulanek PetrBulanek marked this pull request as ready for review January 7, 2025 14:03
@PetrBulanek PetrBulanek requested a review from a team as a code owner January 7, 2025 14:03
# Conflicts:
#	package.json
#	pnpm-lock.yaml
#	src/modules/chat/assistant-plan/PlanStep.tsx
Comment on lines 35 to 50
const { Icon, button } = {
app: {
Icon: AppNotFound,
button: {
label: 'Create your own',
href: `/${project.id}/apps/builder`,
},
},
agent: {
Icon: AgentNotFound,
button: {
label: 'Back to apps',
href: `/${project.id}`,
},
},
}[type];
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not an issue here, but it might be a good practice to memoize it, the object is recreated on each render.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good point. I changed it.

@PetrBulanek PetrBulanek merged commit a9afce3 into main Jan 7, 2025
1 check passed
@PetrBulanek PetrBulanek deleted the post-launch-cleanup-2 branch January 7, 2025 14:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants