Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add Dockerfile for containerized application setup #227

Closed
wants to merge 5 commits into from

Conversation

Aditya-NV-06
Copy link

Which issue(s) does this pull-request address?

Closes: #134

Description

Added a docker container support for the repo.

Checklist

  • I have read the contributor guide
  • Linting passes: yarn lint or yarn lint:fix
  • Formatting is applied: yarn format or yarn format:fix
  • Unit tests pass: yarn test:unit
  • E2E tests pass: yarn test:e2e
  • Tests are included
  • Documentation is changed or added
  • Commit messages and PR title follow conventional commits

@Aditya-NV-06 Aditya-NV-06 requested a review from a team as a code owner December 5, 2024 03:36
@JanPokorny
Copy link
Contributor

JanPokorny commented Dec 5, 2024

Hello! Thank you for your contribution to bee-agent-framework. We value your time and effort.

  • This does not address Add a container executable agent #134 in any way.
  • The Dockerfile isn't valid --node:alpine:latest isn't a valid image specifier.
  • The Dockerfile is actually called DockerFile with capital F, which is not valid.
  • Proper .dockerignore is missing.
  • This project uses yarn.
  • "npm start" doesn't do anything by itself.

We kindly ask you to ensure that you actually run new code before contributing it.

@Tomas2D
Copy link
Contributor

Tomas2D commented Dec 5, 2024

#134 misses clarifying the final goal. How can one implement something that we do not know what it is?
Dockerization is not something that should be part of this library. However, it makes sense to do such a thing at https://github.com/i-am-bee/bee-agent-framework-starter

@Aditya-NV-06
Copy link
Author

Ok I understand your requirements.

@Tomas2D Tomas2D closed this Dec 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add a container executable agent
3 participants