Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(llama-3-1): add trailing new line #22

Merged
merged 1 commit into from
Sep 13, 2024

Conversation

matoushavlena
Copy link
Contributor

@matoushavlena matoushavlena commented Sep 13, 2024

Description

It seems like the official llama 3.1 implementation ends the prompt with \n\n before passing it for inference. Currently only single \n is passed. This has an effect on the inference output.

Supporting evidence:

@Tomas2D Tomas2D merged commit 99ace8f into i-am-bee:main Sep 13, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants