-
Notifications
You must be signed in to change notification settings - Fork 86
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: implement structured generators #19
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JanPokorny
force-pushed
the
janpokorny/feat-implement-structured-generators
branch
from
September 10, 2024 18:28
cc563ca
to
fca8ea8
Compare
JanPokorny
changed the title
Implement structured generators
feat: implement structured generators
Sep 10, 2024
JanPokorny
force-pushed
the
janpokorny/feat-implement-structured-generators
branch
from
September 10, 2024 18:33
fca8ea8
to
2f89572
Compare
Tomas2D
requested changes
Sep 11, 2024
Tomas2D
reviewed
Sep 11, 2024
Tomas2D
reviewed
Sep 11, 2024
Tomas2D
reviewed
Sep 11, 2024
Tomas2D
reviewed
Sep 11, 2024
JanPokorny
force-pushed
the
janpokorny/feat-implement-structured-generators
branch
2 times, most recently
from
September 11, 2024 14:37
29b2986
to
3535206
Compare
JanPokorny
force-pushed
the
janpokorny/feat-implement-structured-generators
branch
from
September 11, 2024 15:51
3535206
to
a9038e8
Compare
Tomas2D
reviewed
Sep 11, 2024
JanPokorny
force-pushed
the
janpokorny/feat-implement-structured-generators
branch
from
September 11, 2024 16:30
a9038e8
to
ecbb1e2
Compare
Tomas2D
approved these changes
Sep 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replace
generateStructured
method by a separateChatLLM
polymorphic wrapper. The original functionality ofgenerateStructured
is replaced byJsonSchemaGenerator
, as evidenced by the examplestructured.ts
. Furthermore, there'sJsonTypeGenerator
that demonstrates the schema to the LLM as a TypeScript type instead of raw JSONSchema (some models like it better), andYamlSchemaGenerator
which uses YAML for both presenting the schema and the response format.