Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(tool): add elasticsearch tool #138

Merged
merged 8 commits into from
Nov 12, 2024
Merged

feat(tool): add elasticsearch tool #138

merged 8 commits into from
Nov 12, 2024

Conversation

abughali
Copy link
Contributor

@abughali abughali commented Nov 4, 2024

Description

This pull request introduces a new ElasticSearchTool, to perform queries against ElasticSearch databases. This tool provides three actions:

  1. LIST_INDICES: Lists all available indices in the ElasticSearch database, excluding system indices.
  2. GET_INDEX_DETAILS: Retrieves detailed field mappings for a specified index.
  3. SEARCH: Executes keyword search or aggregation queries on a specified index with pagination support.

Checklist

  • I have read the contributor guide
  • Linting passes: yarn lint or yarn lint:fix
  • Formatting is applied: yarn format or yarn format:fix
  • Unit tests pass: yarn test:unit
  • E2E tests pass: yarn test:e2e
  • Tests are included
  • Documentation is changed or added
  • Commit messages and PR title follow conventional commits

@abughali abughali requested a review from a team as a code owner November 4, 2024 16:10
Tomas2D
Tomas2D requested changes Nov 4, 2024
View reviewed changes
examples/agents/elasticsearch.ts Outdated Show resolved Hide resolved
examples/agents/elasticsearch.ts Outdated Show resolved Hide resolved
src/tools/database/elasticsearch.test.ts Outdated Show resolved Hide resolved
src/tools/database/elasticsearch.test.ts Show resolved Hide resolved
src/tools/database/elasticsearch.ts Outdated Show resolved Hide resolved
src/tools/database/elasticsearch.ts Outdated Show resolved Hide resolved
src/tools/database/elasticsearch.ts Outdated Show resolved Hide resolved
src/tools/database/elasticsearch.ts Outdated Show resolved Hide resolved
src/tools/database/elasticsearch.ts Outdated Show resolved Hide resolved
src/tools/database/elasticsearch.ts Outdated Show resolved Hide resolved
@abughali abughali requested a review from Tomas2D November 5, 2024 02:35
Tomas2D
Tomas2D requested changes Nov 5, 2024
View reviewed changes
src/tools/database/elasticsearch.ts Outdated Show resolved Hide resolved
@abughali abughali requested a review from Tomas2D November 6, 2024 13:19
Tomas2D
Tomas2D requested changes Nov 6, 2024
View reviewed changes
examples/agents/elasticsearch.ts Show resolved Hide resolved
src/tools/database/elasticsearch.ts Show resolved Hide resolved
src/tools/database/elasticsearch.ts Outdated Show resolved Hide resolved
src/tools/database/elasticsearch.ts Outdated Show resolved Hide resolved
@abughali abughali requested a review from Tomas2D November 6, 2024 20:43
Tomas2D
Tomas2D requested changes Nov 8, 2024
View reviewed changes
src/tools/database/elasticsearch.ts Outdated Show resolved Hide resolved
src/tools/database/elasticsearch.ts Outdated Show resolved Hide resolved
src/tools/database/elasticsearch.ts Outdated Show resolved Hide resolved
src/tools/database/elasticsearch.ts Outdated Show resolved Hide resolved
@abughali abughali requested a review from Tomas2D November 8, 2024 15:32
Tomas2D
Tomas2D approved these changes Nov 12, 2024
View reviewed changes
Copy link
Contributor

@Tomas2D Tomas2D left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I made some changes. But overall, it looks good. Thank you! 🚀

Mahmoud Abughali and others added 8 commits November 12, 2024 17:06
@Tomas2D
feat(tool): add elasticsearch tool
092956d 
Signed-off-by: Mahmoud Abughali <[email protected]>
@Tomas2D
fix: apply suggested changes and fixes
62cec54 
Signed-off-by: Mahmoud Abughali <[email protected]>
@Tomas2D
fix: code style
bb64d4a 
Signed-off-by: Mahmoud Abughali <[email protected]>
@Tomas2D
chore: improve input validation for elastic search tool
0de0783 
Signed-off-by: Mahmoud Abughali <[email protected]>
@Tomas2D
chore: enhance json query validation
6b95065 
Signed-off-by: Mahmoud Abughali <[email protected]>
@Tomas2D
chore: apply suggested changes
60ac512 
Signed-off-by: Mahmoud Abughali <[email protected]>
@Tomas2D
chore: use parseBrokenJson to fix input query
2cf5b20 
Signed-off-by: Mahmoud Abughali <[email protected]>
@Tomas2D
feat(tool): elasticsearch improvements
f34fe23 
Signed-off-by: Tomas Dvorak <[email protected]>
@Tomas2D Tomas2D merged commit 31c3559 into i-am-bee:main Nov 12, 2024
2 checks passed
michael-desmond pushed a commit to michael-desmond/bee-agent-framework that referenced this pull request Nov 12, 2024
@abughali @Tomas2D @michael-desmond
feat(tool): add elasticsearch (i-am-bee#138)
b603265 
Signed-off-by: Mahmoud Abughali <[email protected]>
Signed-off-by: Tomas Dvorak <[email protected]>
Co-authored-by: Mahmoud Abughali <[email protected]>
Co-authored-by: Tomas Dvorak <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Tomas2D Tomas2D Tomas2D approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@abughali @Tomas2D