Upgrade python to 3.11 #8434
Merged
Upgrade python to 3.11 #8434
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marcospri
force-pushed
the
upgrade-python
branch
from
b7c1eaf
to
0f557e6
Compare
marcospri
commented
Jan 12, 2024
| @@ -156,7 +156,7 @@ def test_type_raises_for_unknown_type_of_group(factories): | |||
| def test_you_cannot_set_type(factories): | |||
| group = factories.Group() | |||
|
|
|||
| with pytest.raises(AttributeError, match="can't set attribute"): | |||
| with pytest.raises(AttributeError, match="object has no setter"): | |||
There was a problem hiding this comment.
New version of python produces a new string for the error
| @@ -9,5 +9,5 @@ def test___repr__(self): | |||
|
|
|||
| assert ( | |||
| repr(subscription) | |||
| == "<Subscription uri=http://example.com type=reply active=True>" | |||
| == "<Subscription uri=http://example.com type=Type.REPLY active=True>" | |||
There was a problem hiding this comment.
Not sure about the need for this repr and this test but I will just make it pass in the new python version.
marcospri
force-pushed
the
upgrade-deps
branch
from
2417525
to
1b9a35a
Compare
marcospri
force-pushed
the
upgrade-python
branch
from
0f557e6
to
5ced7f2
Compare
marcospri
force-pushed
the
upgrade-python
branch
from
8e7d8f4
to
2c9253e
Compare
marcospri
force-pushed
the
upgrade-python
branch
from
2c9253e
to
0e54de6
Compare
marcospri
commented
Jan 18, 2024
| @@ -4,7 +4,7 @@ | |||
|
|
|||
| import colander | |||
| import deform | |||
| from jinja2 import Markup | |||
| from markupsafe import Markup | |||
There was a problem hiding this comment.
Upgrading jinja requires some changes of imports.
Comment on lines
+40
to
+41
| markupsafe | ||
| jinja2 |
There was a problem hiding this comment.
No longer need to pin these. We support the latest.
seanh
approved these changes
Jan 18, 2024
Suspect IssuesThis pull request was deployed and Sentry observed the following issues:
Did you find this useful? React with a 👍 or 👎 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For hypothesis/product-backlog#1464
Handling the jinja2 upgrade here as well.