Always include the IPAddressHint in the noderef WIP #859
Conversation
ArneBab
force-pushed
the
always-use-ip-address-hint
branch
from
29eddcf
to
3b52c1e
Compare
ArneBab
force-pushed
the
always-use-ip-address-hint
branch
from
3b52c1e
to
971ea1a
Compare
| if((!hadAddedValidIP || confidence <= 2 || hasIPAddressHint) | ||
| && oldIPAddress != null | ||
| && !oldIPAddress.equals(overrideIPAddress) | ||
| && !addresses.contains(oldIPAddress)) { |
|
@ArneBab, what did I tell you about creating pull requests before you’re actually done with something? 😁 |
This has the "forReviewDontMerge" tag for a reason ☺ |
😡 And I think I already told you the last time you said this that the tag does not prevent an email to be sent. Everybody who is subscribed to this repository because they want to keep up to date with it gets an email about somebody doesn’t know how not to create a pull request for everything they do. Seriously. NOT creating a pull request is way easier than adding a tag. For everybody involved. |
This is a stab at addressing a user-report from FMS that accepting the temporary IP override took 3 ARK uploads.